fix(IconButton): add Storybook controls - #22859
Open
Subhom1 wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for v3-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v2-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22859 +/- ##
==========================================
+ Coverage 89.60% 90.25% +0.64%
==========================================
Files 582 265 -317
Lines 53277 40044 -13233
Branches 7286 2202 -5084
==========================================
- Hits 47738 36140 -11598
+ Misses 5402 3886 -1516
+ Partials 137 18 -119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20928
Completes the IconButton Storybook controls in React and Web Components. Default stories now provide concrete args and correctly typed controls for tooltip behavior, selection, sizing, delays, and alignment. Badge variants expose only the controls they consume, with matching badge count, disabled, and label controls.
The Web Components story now binds
closeOnActivationas a property so setting the control tofalseoverrides the component’struedefault.Changelog
New
hrefcontrol to the Web Components link-based badge story.Changed
childrencontrol because the story intentionally renders a fixed icon.closeOnActivationbinding sofalsevalues work.labelarg.Removed
Testing / Reviewing
Use the repository Node version:
Start React Storybook:
Open
Components/IconButtonand verify:badgeCount,disabled, andlabel.0renders a dot, while positive counts render the number.Start Web Components Storybook:
Open
Components/Icon Buttonand verify:closeOnActivationcan switch betweentrueandfalse.badgeCount,disabled,href, andlabel.Run the focused checks:
Test Screenshots
PR Checklist
As the author of this PR, before marking ready for review, confirm you:
Wrote passing tests that cover this changeTested for cross-browser consistencyMore details can be found in the [pull request guide](https://github.com/carbon-design-system/carbon/blob/main/docs/guides/reviewing-pull-requests.md).