Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update to react 19 #6552

Draft
wants to merge 49 commits into
base: main
Choose a base branch
from

Conversation

matthewgallo
Copy link
Member

@matthewgallo matthewgallo commented Dec 5, 2024

Closes #6553

Adds support for React 19.

A side effect I found from the removal of prop types is the fact that none of the warnings/errors we emit from our custom prop validations are added anymore. This means that any test we previously had to ensure errors/warnings are logged now fail. As React is turning to TypeScript now for type checking, I've removed any tests that checked our old way with custom prop type validations.

Findings:

  • Not able to customize story labels, toolbar in storybook. Maybe this is something storybook is currently working on since the release of React 19 is so new at this point. For example, in packages/core/.storybook/manager.js, rendering anything other than a string for sidebar.renderLabel fails. However, this is now supported with the following storybook addon.
  • Issue with @carbon/react Tabs component, possibly because the version of @carbon/react being used doesn't include React 19 support yet. If this is the case, we'll need to wait until a version supporting React 19 has been published. Resolved with adding [email protected] to our resolutions

What did you change?

How did you test and verify your work?

Confirmed all tests pass, components in storybook render as expected

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 9aa099f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/67e23f7361bebf000813367c
😎 Deploy Preview https://deploy-preview-6552--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 9aa099f
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/67e23f73c68faa0008eea920
😎 Deploy Preview https://deploy-preview-6552--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 98.46154% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.28%. Comparing base (67eacec) to head (9aa099f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6552      +/-   ##
==========================================
- Coverage   81.74%   81.28%   -0.46%     
==========================================
  Files         399      399              
  Lines       12970    12955      -15     
  Branches     4269     4267       -2     
==========================================
- Hits        10602    10531      -71     
- Misses       2368     2424      +56     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React 19: any custom prop type validation needs to be refactored
2 participants