Skip to content

feat(page-header): code connect integration#8868

Open
szinta wants to merge 2 commits intocarbon-design-system:mainfrom
szinta:code-connect-ph-v2-wc
Open

feat(page-header): code connect integration#8868
szinta wants to merge 2 commits intocarbon-design-system:mainfrom
szinta:code-connect-ph-v2-wc

Conversation

@szinta
Copy link
Contributor

@szinta szinta commented Jan 27, 2026

Closes #8633

What did you change?

packages/ibm-products-web-components/src/components/page-header/page-header.figma.ts

How did you test and verify your work?

  • using Figma Dev mode

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request section of
our contributing docs.

@szinta szinta requested a review from a team as a code owner January 27, 2026 11:40
@szinta szinta requested review from amal-k-joy and anamikaanu96 and removed request for a team January 27, 2026 11:40
@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 52c8761
🔍 Latest deploy log https://app.netlify.com/projects/ibm-products-web-components/deploys/6978a43e70b4ba00083ffd5e
😎 Deploy Preview https://deploy-preview-8868--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 52c8761
🔍 Latest deploy log https://app.netlify.com/projects/carbon-for-ibm-products/deploys/6978a43eb8fd240008c969c5
😎 Deploy Preview https://deploy-preview-8868--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 0.68027% with 146 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.98%. Comparing base (73cdab2) to head (52c8761).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8868      +/-   ##
==========================================
- Coverage   80.57%   79.98%   -0.60%     
==========================================
  Files         426      427       +1     
  Lines       19541    19688     +147     
  Branches     4278     4279       +1     
==========================================
+ Hits        15746    15747       +1     
- Misses       3795     3941     +146     
Components Coverage Δ
ibm-products 82.32% <ø> (ø)
ibm-products-web-components 77.13% <0.68%> (-1.29%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Figma Code Connect - web components (PageHeader v2)

2 participants