feat(CoachmarkPatterns): example creation for coachmark patterns#8918
Open
anamikaanu96 wants to merge 1 commit intocarbon-design-system:mainfrom
Open
feat(CoachmarkPatterns): example creation for coachmark patterns#8918anamikaanu96 wants to merge 1 commit intocarbon-design-system:mainfrom
anamikaanu96 wants to merge 1 commit intocarbon-design-system:mainfrom
Conversation
anamikaanu96
requested review from
amal-k-joy and
makafsal
and removed request for
a team
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ Deploy Preview for carbon-for-ibm-products failed. Why did it fail? →
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8918 +/- ##
==========================================
- Coverage 79.69% 79.20% -0.49%
==========================================
Files 432 436 +4
Lines 19910 19790 -120
Branches 4291 4305 +14
==========================================
- Hits 15867 15675 -192
- Misses 4043 4115 +72
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8853
create standalone examples for coachmark related patterns
What did you change?
Separated pattern logic from stories and manually created the StackBlitz examples inside the pattern/ componentName / example
How did you test and verify your work?
yarn storybooknpm iandnpm run devfrom pattern/ componentName / examplePR Checklist
As the author of this PR, before marking ready for review, confirm you:
More details can be found in the pull request section of
our contributing docs.