Add annotations for structs, enums and variants. #34
Conversation
This is required by some libraries, for example: * Serde enum representations (https://serde.rs/enum-representations.html) * Askama templates (https://djc.github.io/askama/creating_templates.html) * postgres-types (https://docs.rs/postgres-types/0.2.0/postgres_types/)
|
also needed for crate modular-bitfield |
src/enum.rs
Outdated
| self.type_def.r#macro(r#macro); | ||
| self | ||
| } | ||
|
|
||
| /// Push a variant to the enum, returning a mutable reference to it. |
There was a problem hiding this comment.
<bike-shedding>
Would it be better to have the function name not be a reserved keyword? it's a minor thing, but perhaps annotation?
</bike-shedding>
src/struct.rs
Outdated
| self.type_def.r#macro(r#macro); | ||
| self | ||
| } | ||
|
|
||
| /// Push a named field to the struct. |
There was a problem hiding this comment.
I'm using this commit generating a file to be used along with modular-bitfield crate. It has structs annotated in the attribute style, e.g. #[bitfield]. For this, i need to use struct.r#macro("#[bitfield]"). To remain consistent with other codegen annotation methods, would it be valuable to use auto-wrap? (e.g. struct.r#macro("bitfield"))
This just means changing line 80 to self.type_def.r#macro(format!("#[{}]", r#macro);
I can see one drawback being that it might make the library a touch more fragile overall.
This is required by some libraries, for example: