Skip to content

Workbench changes #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcolomb merged 7 commits into from
Mar 22, 2023
Merged

Workbench changes #89

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
262cd88
modify link to advanced guidelines
jcolomb Feb 20, 2023
77e82d4
erase comment example (as not working anymore)
jcolomb Feb 20, 2023
691c2e2
update contributing from template
jcolomb Mar 22, 2023
6d5d9e8
update contributing from template 2
jcolomb Mar 22, 2023
6f39ffb
m
jcolomb Mar 22, 2023
6a173ac
try cleaninf
jcolomb Mar 22, 2023
dcef0ec
back to close to template
jcolomb Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ We welcome all contributions to improve the lesson! Maintainers will do their be
questions, concerns, or experience any difficulties along the way.

We'd like to ask you to familiarize yourself with our [Contribution Guide](CONTRIBUTING.md) and have a look at
the [more detailed guidelines][lesson-example] on proper formatting, ways to render the lesson locally, and even
how to write new episodes.
the [more detailed guidelines][workbench] on proper formatting, ways to render the lesson locally, and even
how to write new episodes. Note that we are using the new workbench templates and tooling. Rendering of the lessons is now based on R, via `sandpaper::serve()` while the package is not (yet) on CRAN.

Please see the current list of [issues][FIXME] for ideas for contributing to this
repository. For making your contribution, we use the GitHub flow, which is
Expand Down
1 change: 0 additions & 1 deletion index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ Through lessons learned in this training, researchers will enhance their underst

<p>Funding Acknowledgement: The first iteration of this project was funded by <a href="https://www.turing.ac.uk">The Alan Turing Institute</a> - <a href="https://www.turing.ac.uk/research/asg">AI for Science and Government</a> (ASG) Research Programme from October 2021 to March 2022.</p>

{% comment %} This is a comment in Liquid {% endcomment %}
Copy link
Copy Markdown
Member

@tobyhodges tobyhodges Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could substitute in <!-- HTML comments -->? Or, @zkamvar, is there a specific comment syntax for (R)Markdown files?

Copy link
Copy Markdown
Contributor

@zkamvar zkamvar Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML comments is correct!


:::::::::::::::::::::::::::::::::::::::::: prereq

Expand Down