Fixing several warnings from checking (others still remain) #251
+7
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. `aliasing` slug defined twice.
1. `command` out of order.
1. `function` had a cross-ref to `functions`.
1. `he` (Hebrew) missing from `utils/check-glossary.py`
`make check` still reports these errors---the first comes from no Hebrew section in the configuration, while the others are empty terms.
```
missing languages in configuration: {'he'}
No language entries for entry {'slug': 'causation'}
No language entries for entry {'slug': 'constant'}
No language entries for entry {'slug': 'degrees_of_freedom'}
No language entries for entry {'slug': 'directory'}
No language entries for entry {'slug': 'geometric_mean'}
No language entries for entry {'slug': 'harmonic_mean'}
No language entries for entry {'slug': 'independent_variable'}
No language entries for entry {'slug': 'masking'}
No language entries for entry {'slug': 'posterior_distribution'}
No language entries for entry {'slug': 'shiny'}
No language entries for entry {'slug': 'test_data'}
No language entries for entry {'slug': 'training_data'}
```
fmichonneau
approved these changes
Dec 14, 2020
|
Hebrew was added to the file in #224 but it hasn't been merged yet. |
|
I've created a new Issue, #253, to track the empty slugs so we can fill them in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aliasingslug defined twice.commandout of order.functionhad a cross-ref tofunctions.he(Hebrew) missing fromutils/check-glossary.pymake checkstill reports these errors---the first comes from no Hebrew section in the configuration, while the others are empty terms.