Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http -> https links that were missed during the transition #1519

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Mar 31, 2023

This does a couple of things:

  1. fixes all http -> https links in the non-episode files (majority of which were in demo lessons)
  2. adds anchors to headings and replaces the phantom anchors (to fix switch jump links to use identifiers  #1497)
  3. fixes warnings about missing files

zkamvar added 3 commits March 31, 2023 10:44
During my processing of this lesson, I had not enabled link validation
of the auxilary markdown files (that is, non-episode files), so a lot of
them had https links and sneaky ways of creating anchor links that were
not accessible
(see
#1497 (comment))

As of the update to {pegboard} 0.5.0, these external files are now
processed.
I have updated the anchor links in instructor notes and checkout so that
they will be consistent

This will fix #1497
@github-actions
Copy link

github-actions bot commented Mar 31, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries/instructor-training/compare/md-outputs..md-outputs-PR-1519

The following changes were observed in the rendered markdown documents:

 LICENSE.md          |  19 +++---
 checkout.md         |  12 ++--
 demo_lessons.md     | 190 ++++++++++++++++++++++++++--------------------------
 index.md            |   6 +-
 instructor-notes.md |  25 +++----
 md5sum.txt          |  12 ++--
 members.md          |   2 +-
 7 files changed, 131 insertions(+), 135 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-03-31 18:02:37 +0000

github-actions bot pushed a commit that referenced this pull request Mar 31, 2023
@karenword karenword merged commit 8b15f79 into main Apr 3, 2023
@karenword karenword deleted the znk-fix-links branch April 3, 2023 20:09
github-actions bot pushed a commit that referenced this pull request Apr 3, 2023
Auto-generated via {sandpaper}
Source  : 8b15f79
Branch  : main
Author  : Karen Word <[email protected]>
Time    : 2023-04-03 20:09:40 +0000
Message : Merge pull request #1519 from carpentries/znk-fix-links

Fix http -> https links that were missed during the transition
github-actions bot pushed a commit that referenced this pull request Apr 3, 2023
Auto-generated via {sandpaper}
Source  : 5024af6
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-04-03 20:12:18 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 8b15f79
Branch  : main
Author  : Karen Word <[email protected]>
Time    : 2023-04-03 20:09:40 +0000
Message : Merge pull request #1519 from carpentries/znk-fix-links

Fix http -> https links that were missed during the transition
github-actions bot pushed a commit that referenced this pull request Apr 4, 2023
Auto-generated via {sandpaper}
Source  : 8b15f79
Branch  : main
Author  : Karen Word <[email protected]>
Time    : 2023-04-03 20:09:40 +0000
Message : Merge pull request #1519 from carpentries/znk-fix-links

Fix http -> https links that were missed during the transition
github-actions bot pushed a commit that referenced this pull request Apr 4, 2023
Auto-generated via {sandpaper}
Source  : a871528
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-04-04 00:12:30 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 8b15f79
Branch  : main
Author  : Karen Word <[email protected]>
Time    : 2023-04-03 20:09:40 +0000
Message : Merge pull request #1519 from carpentries/znk-fix-links

Fix http -> https links that were missed during the transition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch jump links to use identifiers
2 participants