Add view logs support, bold button for start/pause, bump Kotlin/Gradle #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpawliszyn
reviewed
Jan 30, 2025
| @@ -204,7 +204,7 @@ class VariableCapacityChannelTest { | |||
| @Test | |||
| fun `listener is called`() { | |||
| val size = AtomicInteger() | |||
| runBlockingTest { | |||
There was a problem hiding this comment.
Did we mean to do these?
There was a problem hiding this comment.
Part of the Kotlin 2 upgrade
There was a problem hiding this comment.
Reverting to do in a separate PR
adrw
force-pushed
the
2025-01-28.logs
branch
from
d236f42 to
b88dc39
Compare
mpawliszyn
reviewed
Feb 11, 2025
build.gradle.kts
Outdated
| } | ||
| } | ||
|
|
||
| tasks.withType<JavaCompile> { | ||
| sourceCompatibility = JavaVersion.VERSION_11.toString() | ||
| targetCompatibility = JavaVersion.VERSION_11.toString() | ||
| sourceCompatibility = JavaVersion.VERSION_17.toString() |
There was a problem hiding this comment.
I'm not sure we can do this? I think this will lock out anyone < 17 right?
mpawliszyn
approved these changes
Feb 11, 2025
adrw
force-pushed
the
2025-01-28.logs
branch
from
17976b5 to
22a5ae3
Compare
adrw
force-pushed
the
2025-01-28.logs
branch
from
22a5ae3 to
c9373be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Misk was causing failures when trying to start the development service so the Kotlin/Gradle upgrade was necessary to unblock forward development.
View logs link now works and there are bolder start/pause buttons in the Backfill Show page.