Bump Misk and Kotlin 2 #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
adrw
commented
Feb 11, 2025
•
adrw
commented
- Fix Kotlin Coroutines deprecation warnings currently failing tests
adrw
force-pushed
the
2025-02-11.bump
branch
3 times, most recently
from
7ac052c to
e2c8cc6
Compare
adrw
force-pushed
the
2025-02-11.bump
branch
from
e2c8cc6 to
dd28ca1
Compare
katukota
approved these changes
Feb 20, 2025
|
LG! |
mpawliszyn
reviewed
Feb 20, 2025
| @@ -214,23 +192,13 @@ class VariableCapacityChannelTest { | |||
| val receiveChannel = variableCapacityChannel.proxy(this) | |||
| assertThat(size.get()).isEqualTo(0) | |||
|
|
|||
| upstream.trySend("test").isSuccess | |||
| assertThat(size.get()).isEqualTo(1) | |||
There was a problem hiding this comment.
I think we still want this count?
There was a problem hiding this comment.
A lot of these assertions relied on being run in a blocking test and are impacted by the coroutine scheduling which is inconsistent, hence why most of them were removed in the version bump which moves the tests to run in regular coroutines.
shellderp
approved these changes
Feb 20, 2025
adrw
force-pushed
the
2025-02-11.bump
branch
from
0cabed8 to
125d759
Compare
|
Thanks @swankjesse for pairing on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.