Fix Windows build failures for cklib and CMake tasks #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

crowforkotlin wants to merge 1 commit into cashapp:trunk from crowforkotlin:trunk-windows-cl

Contributor

crowforkotlin commented Sep 27, 2025

PR

This PR mainly fixes some errors caused by compiling the project on Windows. After modification, it is also verified that the project can be compiled successfully on Windows WSL Ubuntu system.

ChanegList

Fixed a CONFIG_VERSION escaping issue on Windows and verified that the project compiles successfully on WSL Ubuntu.

Test Command

The testing tasks are as follows:
./gradlew zipline:buildCMakeDebug
./gradlew zipline:allQuickjs

Reproducing the issue

cklib_error_windows

cmake_error_windows

Fix


          Fix Windows build failures for cklib and CMake tasks

64f53ea

crowforkotlin mentioned this pull request

Add Windows JVM support #1680

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet