Skip to content

Conversation

@asmogo
Copy link
Collaborator

@asmogo asmogo commented Sep 24, 2025

Description

Still in draft because of these prerequisites


Notes to the reviewers


Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED


Checklist

@github-actions
Copy link
Contributor

This PR is stale because it has been open for 60 days with no activity.

@asmogo
Copy link
Collaborator Author

asmogo commented Jan 15, 2026

I think we should move forward and merge this one as well. The only downside is that we are forced to downgrade the uniffi crate to 0.28.3

@asmogo asmogo marked this pull request as ready for review January 15, 2026 09:22
@thesimplekid
Copy link
Collaborator

I think we should move forward and merge this one as well. The only downside is that we are forced to downgrade the uniffi crate to 0.28.3

I don't mind downgrading now as I don't think we lose anything we're using. I do think there are a few things in recent versions we may want to take advantage of, but nothing we need right now that blocks downgrading. My only concern would be we get stuck there if the go generator never upgrades.

It seems ldk-node is on 0.28.3 as well for this reason lightningdevkit/ldk-node#733 (comment).

Another potential issue is if the dart generator gets to a state where we can use it but requires lets say 0.30.0 but were stuck on 0.28.3 to support go, we're in a position of having to choose to drop the go support in order to upgrade. But since that is not ready yet I believe, hopefully go upgrades by then.

cc @davidcaseria do you think downgrading is okay?

@ye0man ye0man added this to CDK Jan 15, 2026
@github-project-automation github-project-automation bot moved this to Backlog in CDK Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants