rename ln settings in toml configuration #1127
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace Ln/LnBackend with Backend/BackendType across mintd - Move settings.ln.ln_backend to settings.backend.name - Update example config: [ln] -> [backend], ln_backend -> name - Adjust env var mapping and internal references accordingly - Add serde aliases for fake_wallet and grpc_processor - Improve config loading diagnostics (log path, write snapshot) - Update integration tests to the new settings schema BREAKING CHANGE: rename config table and key: - [ln] -> [backend] - ln_backend -> name
Collaborator
Author
|
should we do prefixes to the payment_backends? like This would be consistent with the database configuration. |
Collaborator
Yes I think this is better |
Consolidate all payment backend settings under [payment_backend]
Replace backend.name with payment_backend.kind
Move per-backend sections to payment_backend.<backend>
Update Settings and env var loading to read nested backend configs
Update example config and integration tests to new layout
BREAKING CHANGE:
- TOML:
- [backend].name -> [payment_backend].kind
- [cln], [lnd], [ldk_node], [lnbits], [fake_wallet], [grpc_processor]
-> [payment_backend.<backend>]
- kind "fakewallet" renamed to "fake_wallet"
- Env vars:
- CDK_MINTD_CLN_* -> CDK_MINTD_PAYMENT_BACKEND_CLN_*
- CDK_MINTD_LND_* -> CDK_MINTD_PAYMENT_BACKEND_LND_*
- CDK_MINTD_FAKE_WALLET_* ->
CDK_MINTD_PAYMENT_BACKEND_FAKE_WALLET_*
- CDK_MINTD_GRPC_PAYMENT_PROCESSOR_* ->
CDK_MINTD_PAYMENT_BACKEND_GRPC_PAYMENT_PROCESSOR_*
asmogo
force-pushed
the
config/refactor
branch
from
9562d0e to
58644b8
Compare
# Conflicts: # crates/cdk-mintd/example.config.toml # crates/cdk-mintd/src/config.rs # crates/cdk/src/mint/start_up_check.rs # docker-compose.yaml
Collaborator
Author
|
I have updated this to be backwards compatible with the old config 60037e7 We print deprecation warnings to std out if we see the old [ln] configuration is still active. |
Collaborator
|
Tried this with my existing config and worked and got the expected warning. Is there anything else you have left here or think its good? ACK b00c944 This does not rename anything that gets added to the db so we don't have to migrate anything there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BREAKING CHANGE: rename config table and key:
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just final-checkbefore committing