-
Notifications
You must be signed in to change notification settings - Fork 111
feat(cashu): add NUT-26 bech32m encoding for payment requests #1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
03ada58 to
5388c28
Compare
Contributor
|
This PR is stale because it has been open for 60 days with no activity. |
8764278 to
6a9710a
Compare
f8f6d7c to
a30c1a4
Compare
Implements NUT-26 specification providing bech32m encoding (CREQ-B) as an alternative to the CBOR format (CREQ-A). The new encoding offers improved QR code compatibility and more efficient encoding. - Add complete NUT-26 encoding/decoding implementation with TLV structure - Update PaymentRequest::from_str to support both CREQ-A and CREQ-B formats - Add comprehensive test vectors and documentation - Add benchmark example for encoding performance comparison
a30c1a4 to
542c229
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements NUT-26 specification providing bech32m encoding (CREQ-B) as an alternative to the CBOR format (CREQ-A). The new encoding offers improved QR code compatibility and more efficient encoding.
Description
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just final-checkbefore committing