remove wallet database transaction support #1472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesimplekid
force-pushed
the
remove_wallet_tx
branch
5 times, most recently
from
03c89d7 to
11b54b1
Compare
thesimplekid
force-pushed
the
remove_wallet_tx
branch
from
11b54b1 to
1d62c37
Compare
thesimplekid
force-pushed
the
remove_wallet_tx
branch
from
1d62c37 to
a0e71a5
Compare
thesimplekid
force-pushed
the
remove_wallet_tx
branch
from
a0e71a5 to
5bb5dc6
Compare
Remove DatabaseTransaction trait to support databases without native transaction support (IndexedDB, FFI bindings, LDK's KVStore). The saga pattern will handle failure recovery instead of relying on database transactions. - Remove DatabaseTransaction trait and begin_db_transaction method - Move transaction methods to direct Database trait methods feat: wallet kv tests
thesimplekid
force-pushed
the
remove_wallet_tx
branch
from
41c0975 to
d4466f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove DatabaseTransaction trait to support databases without native transaction support (IndexedDB, FFI bindings, LDK's KVStore).
The saga pattern will handle failure recovery instead of relying on database transactions.
- Remove DatabaseTransaction trait and begin_db_transaction method
- Move transaction methods to direct Database trait methods
Saga impl: thesimplekid#16
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just final-checkbefore committing