feat: Mint reporting rpc #1487
Open
feat: Mint reporting rpc #1487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleans up the mint info cli output (formatting) adds tos_url to the mint info output adds method to mutate tos_url
This updates the RPC to isolate function responsibility CdkMintManagementClient CdkMintDataClient existing methods are setup to use management get_info has been migrated to data
This moves server methods into their respective files, management and reporting This also renames the 'data' proto and it's methods to 'reporting' This is more explicit in it's purpose. Better fit.
cleans up the mint info cli output (formatting) adds tos_url to the mint info output adds method to mutate tos_url
This updates the RPC to isolate function responsibility CdkMintManagementClient CdkMintDataClient existing methods are setup to use management get_info has been migrated to data
This moves server methods into their respective files, management and reporting This also renames the 'data' proto and it's methods to 'reporting' This is more explicit in it's purpose. Better fit.
…-tap into feature/mint-data-rpc
This adds the keysets rpc method. There are some compromises here. 1) no proof counts - sort of an expensive request without a cache 2) cannot get date info or deriv path index - would need more code in other crates i believe. will evaluate later.
+ custom sql for list method
Collaborator
|
Can we do this issue as part of this? #1093 |
Author
Yes, this issue gets addressed in the PR. |
The data we do not currently fetch should return as null valid_from valid_to deviation_path_index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR splits the mint gRPC API into management and reporting services.
Mint reporting endpoints are introduced to expose mint records (balances, keysets, quotes, proofs, signatures, operations).
Mint management endpoints were added (update_tos_url, create_backup).
Notes to the reviewers
There is one outstanding shortcoming with this PR
Changes are required to core traits to expose this information
Some features were not included in with this PR that are may be candidates for future improvement
There are 'breaking' changes in this PR as the current proto file was renamed and reorganized. Consumers will be required to change their implementation to support this release.
Suggested CHANGELOG Updates
CHANGED
get-infoand is now on a dedicatedget-balancesmethodADDED
tos_urltoget_infoand addedupdate_tos_urlrpc methodChecklist
just final-checkbefore committing