chore: weekly agenda sorts PRs by type #1498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In the weekly agenda, filter and sort items first by type. Feat, Fix, Refactor, Chore, Docs, CI, Test, and everything else. - Also adds in the last weeks merged PRs from the nuts repo.
TheRealCheebs
changed the title
Collaborator
|
Nice. I think it would also be nice if we could do something about the backports maybe just put them in their own section as they're good to document but we don't really need to talk about them since there is a corresponding pr. |
- Filters the backports into their own section. - Skips the inclusion of "Weekly Meeting Agenda"
Contributor
Author
|
bash... sigh... I think this looks like what you were manually doing for the backports. I ran it for the last 30 days and saw " refactor: remove redundant..." and a few other little things that will drive me mad. But my goal in this was mostly just to have the conversation stay focused by "external stakeholder impact" vs jumping from chore to bug to feature to whatever. I pulled out the weekly meeting agenda too. I thought it would be good to do #1483 along with this but the commits already have the typos in them, so that should be fixed upstream of this, right? |
Contributor
Author
|
@thesimplekid I did run it on my fork but the workflow file uses the current repo (my fork) and not upstream, so all you see is the merged nuts section. If needed I can commit to the workflow file to remove the GITHUB_REPOSITORY so it points here to have the action generate the expected file and then revert. Let me know what you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the weekly agenda, resort the PR items by type, this way when going through the list they can be grouped by feat, fix, refactor, chore... I used a handful from the commitizen check list. If it doesn't fit they end up at the end all still sorted by number.
Also adds in the last weeks merged PRs from the nuts repo.
just final-checkbefore committing