Skip to content

Conversation

@callebtc
Copy link
Contributor

@callebtc callebtc commented Jan 8, 2026

Expose active and input_fee_ppk fields on keysets returned from /v1/keys endpoint and align the /v1/keys/{keyset_id} example accordingly.

This allows wallets to compute the keyset ID and access associated keyset metadata directly from the /keys response without requiring an additional round-trip to the /keysets endpoint.

closes #289

Expose `active` and `input_fee_ppk` on keysets returned from `/v1/keys` and align the `/v1/keys/{keyset_id}` example accordingly.

This lets wallets derive the keyset ID and associated keyset metadata from the `/keys` payload without an extra round-trip to `/keysets`.
@prusnak
Copy link
Collaborator

prusnak commented Jan 8, 2026

We probably need the final_expiry field too, right?

@callebtc
Copy link
Contributor Author

callebtc commented Jan 8, 2026

We probably need the final_expiry field too, right?

yes, that would have to wait for or be merged into the keyset v2 PR

Copy link
Collaborator

@thesimplekid thesimplekid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b48eeb8

@robwoodgate
Copy link
Contributor

Will resolve issue: #289

Copy link
Contributor

@robwoodgate robwoodgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK @ b48eeb8

@callebtc callebtc merged commit cc6d06f into main Jan 11, 2026
2 checks passed
@ye0man ye0man added this to nuts Jan 13, 2026
@github-project-automation github-project-automation bot moved this to Backlog in nuts Jan 13, 2026
@github-project-automation github-project-automation bot moved this from Backlog to Done in nuts Jan 13, 2026
@ye0man ye0man removed this from nuts Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/v1/keys endpoint should include input_fee_ppk

5 participants