-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update syntax highlighting to match vscode #34
Conversation
{ | ||
"name": "Variable declaration", | ||
"scope": "keyword.declaration", | ||
"foreground": "var(mauve)", | ||
"font_style": "italic" | ||
}, | ||
{ | ||
"name": "Class declaration", | ||
"scope": "keyword.declaration.class", | ||
"foreground": "var(mauve)", | ||
"font_style": "italic" | ||
}, | ||
{ | ||
"name": "Function declaration", | ||
"scope": "keyword.declaration.function", | ||
"foreground": "var(mauve)", | ||
"font_style": "italic" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems impossible to combine these into one setting with multiple scopes for some reason, not sure why but it kept not working for me.
Keywords should be mauve and the punctuation should be overlay2, as per the style guide. JetBrains, VSCode and the newer things we've merged follow this. I honestly didn't realise how far behind Sublime was here, it'll be good to get this merged. The justification of following VSCode is quite common lol. |
The main justification is indeed the Catppuccin style guide, where the use of the colors (including mauve, as implemented in the PR) is described. VS Code (and |
Fine.
I'm unsympathetic to this argument because I don't use VSCode.
The reason Bat matches VSCode is because the Bat port was deleted, and replaced with code that auto-generates the theme from VSCode. |
Whether you like it or not, it has become the standard. If you want to suggest improvements to the syntax highlighting standard, I suggest opening discussions/issues/PRs to the catppuccin/catppuccin repository (and style guide within). If changes are made to the style guide with regard to syntax highlighting I'd be happy to update all the downstream ports to match. |
It's not so much about the editor but it was just the first one that we revamped properly with the new style guide in mind. If we started with Sublime then it would have been VSCode getting these PRs with "just follow Sublime" In any case, a more thorough and detailed style guide is required for us to stop recommending what VSCode currently does. |
Closes #33.