-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nodejs): init #1246
base: main
Are you sure you want to change the base?
feat(nodejs): init #1246
Conversation
.language-js { | ||
color: @text !important; | ||
background-color: @mantle !important; | ||
} | ||
.hljs-comment { | ||
color: @overlay2 !important; | ||
} | ||
.hljs-number, | ||
.hljs-literal { | ||
color: @peach !important; | ||
} | ||
.hljs-built_in, | ||
.hljs-variable { | ||
color: @red !important; | ||
} | ||
.hljs-keyword { | ||
color: @mauve !important; | ||
} | ||
.hljs-string { | ||
color: @green !important; | ||
} | ||
.hljs-regexp { | ||
color: @pink !important; | ||
} | ||
.function_ { | ||
color: @blue !important; | ||
} | ||
.hljs-meta { | ||
color: @mauve !important; | ||
} | ||
.class_, | ||
.hljs-type { | ||
color: @yellow !important; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#column2 li:hover { | ||
background-color: lighten(@mantle, 10%) !important; | ||
} | ||
|
||
#column2 hr { | ||
border-color: @surface0 !important; | ||
} | ||
|
||
#column2 li a.active { | ||
color: lighten(@text, 10%) | ||
} | ||
|
||
#column2 li a { | ||
color: @text; | ||
text-decoration: none; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to use nesting when possible: https://lesscss.org/features/#parent-selectors-feature.
a code, | ||
a { | ||
color: @accent-color; | ||
} | ||
|
||
a:hover, | ||
a code:hover { | ||
background-color: @surface0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nesting would work great here as well.
nodejs: | ||
name: NodeJS | ||
categories: [development] | ||
color: mauve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
color: mauve | |
icon: nodedotjs | |
color: green |
I should note that the Node.js documentation, like the website, has a redesign in the works: https://togithub.com/nodejs/node/issues/52343. |
Oh thanks for letting me know! I've looked at that issue and looks like they're changing the design quite significantly And looks like over the months they have been making steady progress with it. I'll just wait until they deploy the new docs then I'll rework this PR. Is that fine? We can keep it as draft in the meantime? |
I mean I'm okay merging with the current state assuming it correctly themes the existing docs! Up to you. |
🎉 Theme for NodeJS🎉
NodeJS is a javascript runtime, the nodejs website includes docs for it
💬 Additional Comments 💬
Difficulties
Right-clicking on these breadcrumbs applies a green background and at the moment I dont know how to remove it. none of the pseudoclasses work and it doesn't gain any additional class.
Same behaviour can be observed in a few different places, if i can figure out how to fix it here I'll probably be able to fix it in those places too
🗒 Checklist 🗒
/styles/<name-of-website>
containing the contents of the/template
directory.userstyles.yml
file with information about the new userstyle.
catppuccin.user.css
- all the CSS for the userstyle, based on thetemplate.
preview.webp
- composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.