Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nodejs): init #1246

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

nikitarevenco
Copy link
Contributor

🎉 Theme for NodeJS🎉

NodeJS is a javascript runtime, the nodejs website includes docs for it

💬 Additional Comments 💬

Difficulties

Right-clicking on these breadcrumbs applies a green background and at the moment I dont know how to remove it. none of the pseudoclasses work and it doesn't gain any additional class.

Same behaviour can be observed in a few different places, if i can figure out how to fix it here I'll probably be able to fix it in those places too
image

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

Comment on lines +175 to +208
.language-js {
color: @text !important;
background-color: @mantle !important;
}
.hljs-comment {
color: @overlay2 !important;
}
.hljs-number,
.hljs-literal {
color: @peach !important;
}
.hljs-built_in,
.hljs-variable {
color: @red !important;
}
.hljs-keyword {
color: @mauve !important;
}
.hljs-string {
color: @green !important;
}
.hljs-regexp {
color: @pink !important;
}
.function_ {
color: @blue !important;
}
.hljs-meta {
color: @mauve !important;
}
.class_,
.hljs-type {
color: @yellow !important;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +136 to +151
#column2 li:hover {
background-color: lighten(@mantle, 10%) !important;
}

#column2 hr {
border-color: @surface0 !important;
}

#column2 li a.active {
color: lighten(@text, 10%)
}

#column2 li a {
color: @text;
text-decoration: none;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to use nesting when possible: https://lesscss.org/features/#parent-selectors-feature.

Comment on lines +113 to +121
a code,
a {
color: @accent-color;
}

a:hover,
a code:hover {
background-color: @surface0;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nesting would work great here as well.

nodejs:
name: NodeJS
categories: [development]
color: mauve
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
color: mauve
icon: nodedotjs
color: green

@uncenter
Copy link
Member

I should note that the Node.js documentation, like the website, has a redesign in the works: https://togithub.com/nodejs/node/issues/52343.

@nikitarevenco
Copy link
Contributor Author

I should note that the Node.js documentation, like the website, has a redesign in the works: https://togithub.com/nodejs/node/issues/52343.

Oh thanks for letting me know! I've looked at that issue and looks like they're changing the design quite significantly
image

And looks like over the months they have been making steady progress with it. I'll just wait until they deploy the new docs then I'll rework this PR. Is that fine? We can keep it as draft in the meantime?

@uncenter
Copy link
Member

I mean I'm okay merging with the current state assuming it correctly themes the existing docs! Up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants