Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alternativeto): init #1265

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

thismoon
Copy link
Contributor

@thismoon thismoon commented Sep 5, 2024

🎉 Theme for AlternativeTo 🎉

AlternativeTo is a crowdsourced software recommendation website that lists alternatives to software. it allows users to vote on alternatives and leave text reviews. it also lists key features and allows filtering alternatives (e.g. alternatives to photoshop that support linux and are open source)

preview.webp converted to jpg using ffmpeg

💬 Additional Comments 💬

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@thismoon thismoon requested a review from a team as a code owner September 5, 2024 14:00
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When hovering the items in the nav bar they seem to go white, this only happens on the light theme.
{6700E9C4-98AD-47FF-BFBF-82A56244D81E}

The left most circle seems to grow when using the catppuccin theme.
{0B60829A-7A4D-4ECE-9760-73224D1B8E0B}

Also noticing some light text on an accent background, ideally the text should be curst.
{DB3D1801-6A3C-4065-A273-31CAF8C54A9B}

&,
& p a,
& [class^="Footer_footerMenu"] li a {
color: lighten(@accent-color, 10%);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
color: lighten(@accent-color, 10%);
color: @text;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops i accidentally merged this without testing it. this breaks in light mode
image
i will revert it to
image
unless you want it to be text color normally and crust on light mode, i will keep it a lighter accent color. because this is closer to how the unthemed website looks like
image

Comment on lines 68 to 74
--mainBrand: if(
@lookup = latte,
lighten(@accent-color, 10%),
darken(@accent-color, 50%)
);
--topBrand: darken(@accent-color, 10%);
--footer: darken(@accent-color, 50%);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--mainBrand: if(
@lookup = latte,
lighten(@accent-color, 10%),
darken(@accent-color, 50%)
);
--topBrand: darken(@accent-color, 10%);
--footer: darken(@accent-color, 50%);
--mainBrand: @accent-color;
--topBrand: @accent-color;
--footer: @accent-color;

I don't get the point of the darkening.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the header is darker on darkmode but i might just not darken it and make the text color crust instead
i agreen on changing --topBrand
the footer of the website should be a darker shade of the accent (this is what the unthemed website does)
im going to make manual changes instead of directly committing these suggestions

@uncenter
Copy link
Member

Header text is pretty much unreadable.

Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are willing to go all in I think theming these app store links would be nice. Maybe just the most common ones, like these three stores and the GitHub one?

CleanShot 2024-09-14 at 20 38 52

@uncenter
Copy link
Member

uncenter commented Sep 15, 2024

Just make the header normal accent colored and the footer mantle + text.

@thismoon
Copy link
Contributor Author

(the github icon is monochrome so it doesn't need special theming)
image

Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Text of search results is not visible.

@uncenter
Copy link
Member

The text and close button of this modal is unthemed. Small but if you have a chance would be great :)
CleanShot 2024-09-18 at 14 34 35

Log out, go to https://alternativeto.net/software/yaak/about/, click the heart/like/upvote button, and this modal will pop up prompting you to register.

@uncenter
Copy link
Member

Theming https://auth.alternativeto.net/ would also be appreciated.

@uncenter
Copy link
Member

These account related settings buttons are unthemed:
CleanShot 2024-09-18 at 14 39 24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants