-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(google-gemini): remove weird shadows #1624
base: main
Are you sure you want to change the base?
Conversation
I can't reproduce your issue: |
Could it be that because I have Gemini Advanced, the page is slightly different? It's still not fixed in my case. I also noticed my hallucination warning is slightly different Here's the related HTML for the small section on bottom, cleaned up some angular and inline styles from here: <input-container class="response-optimization ng-star-inserted">
<div class="input-area-container ng-star-inserted">
<input-area-v2>
<input-area-content class="ng-star-inserted">
<div data-node-type="input-area" class="input-area">
<div xapfileselectordropzone="" class="text-input-field">
<div class="leading-actions-wrapper ng-star-inserted">
<uploader maticonprefix="" class="upload-button ng-star-inserted">
<div cdk-overlay-origin="" class="file-uploader ng-star-inserted">
<div class="mat-mdc-tooltip-trigger mat-mdc-tooltip-disabled">
<button mat-icon-button="" aria-label="Open upload file menu"
class="mat-mdc-tooltip-trigger upload-card-button open mdc-icon-button mat-mdc-icon-button mat-unthemed mat-mdc-button-base ng-star-inserted"
mat-ripple-loader-class-name="mat-mdc-button-ripple" mat-ripple-loader-centered=""
mat-ripple-loader-disabled="" aria-describedby="cdk-describedby-message-ng-1-3"
cdk-describedby-host="ng-1">
<span class="mat-mdc-button-persistent-ripple mdc-icon-button__ripple"></span>
<mat-icon role="img"
class="mat-icon notranslate google-symbols mat-ligature-font mat-icon-no-color"
aria-hidden="true" data-mat-icon-type="font" data-mat-icon-name="add_2"
fonticon="add_2"></mat-icon>
<span class="mat-focus-indicator"></span><span class="mat-mdc-button-touch-target"></span><span
class="mat-ripple mat-mdc-button-ripple"></span>
</button>
</div>
</div>
<button tabindex="-1" xapfileselectortrigger="" aria-hidden="true"
data-test-id="hidden-local-image-upload-button" class="hidden-local-upload-button"></button>
</uploader>
</div>
<div class="text-input-field_textarea-wrapper" style="--chat-container-height: 282;">
<div class="text-input-field-main-area">
<div class="text-input-field_textarea-inner" style="height: 24px;">
<rich-textarea atmentions=""
class="text-input-field_textarea ql-container ql-bubble ng-untouched ng-pristine ng-valid ng-star-inserted"
enterkeyhint="send" dir="ltr" style="--textarea-max-rows: 7; --chat-container-height: 282px;">
<div class="ql-editor ql-blank textarea new-input-ui" data-gramm="false" contenteditable="true"
role="textbox" aria-multiline="true" aria-label="Enter a prompt here"
data-placeholder="Ask Gemini">
<p><br></p>
</div>
<div class="ql-clipboard" contenteditable="true" tabindex="-1"></div>
</rich-textarea>
<at-mentions-menu class="ng-star-inserted">
<mat-menu>
</mat-menu>
</at-mentions-menu>
</div>
</div>
</div>
<div class="trailing-actions-wrapper">
<div class="input-buttons-wrapper-bottom">
<div class="mic-button-container ng-trigger ng-trigger-slide ng-star-inserted">
<speech-dictation-mic-button class="ng-star-inserted" style="">
<button data-node-type="speech_dictation_mic_button" maticonsuffix="" mat-icon-button=""
mattooltip="Use microphone" aria-label="Microphone"
class="mat-mdc-tooltip-trigger speech_dictation_mic_button mdc-icon-button mat-mdc-icon-button mat-unthemed mat-mdc-button-base"
mat-ripple-loader-uninitialized="" mat-ripple-loader-class-name="mat-mdc-button-ripple"
mat-ripple-loader-centered="" aria-describedby="cdk-describedby-message-ng-1-4"
cdk-describedby-host="ng-1">
<span class="mat-mdc-button-persistent-ripple mdc-icon-button__ripple"></span>
<div>
<mat-icon role="img"
class="mat-icon notranslate icon-filled google-symbols mat-ligature-font mat-icon-no-color"
aria-hidden="true" data-mat-icon-type="font" data-mat-icon-name="mic"
fonticon="mic"></mat-icon>
</div>
<span class="mat-focus-indicator"></span><span class="mat-mdc-button-touch-target"></span>
</button>
</speech-dictation-mic-button>
</div>
<div
class="mat-mdc-tooltip-trigger send-button-container disabled inner mat-mdc-tooltip-disabled ng-star-inserted">
<button mat-icon-button="" aria-label="Send message"
class="send-button mdc-icon-button mat-mdc-icon-button submit mat-unthemed mat-mdc-button-base ng-star-inserted"
mat-ripple-loader-uninitialized="" mat-ripple-loader-class-name="mat-mdc-button-ripple"
mat-ripple-loader-centered="" tabindex="-1" aria-disabled="true">
<span class="mat-mdc-button-persistent-ripple mdc-icon-button__ripple"></span>
<mat-icon role="img" fonticon="send"
class="mat-icon notranslate send-button-icon icon-filled google-symbols mat-ligature-font mat-icon-no-color"
aria-hidden="true" data-mat-icon-type="font" data-mat-icon-name="send"></mat-icon>
<span class="mat-focus-indicator"></span><span class="mat-mdc-button-touch-target"></span>
</button>
</div>
</div>
</div>
</div>
</div>
</input-area-content>
</input-area-v2>
</div>
<hallucination-disclaimer class="ng-star-inserted">
<div class="capabilities-disclaimer">
<p data-test-id="empty-disclaimer" class="gds-label-m-alt desktop-spacing ng-star-inserted">
<br class="ng-star-inserted">
</p>
</div>
</hallucination-disclaimer>
</input-container> |
🔧 What does this fix? 🔧
Fixes some weird lingering shadow issues on the Gemini Website. Seems similar to #1406 that was fixed in #1410. Looks like the CSS for the site was updated again and that broke it.
Before the fix:
![image](https://private-user-images.githubusercontent.com/22198661/410163372-53cb8422-43aa-47e7-a970-a18961c4b555.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTc5MzUsIm5iZiI6MTczOTU5NzYzNSwicGF0aCI6Ii8yMjE5ODY2MS80MTAxNjMzNzItNTNjYjg0MjItNDNhYS00N2U3LWE5NzAtYTE4OTYxYzRiNTU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA1MzM1NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVjOTZjZjc2ZGY2YThmZjA5Y2RlYjBlYTE1YTNmMDg2Y2VmM2IzYmQyZjIxNjM2MmExY2VjMTRlNWNiYWEwNTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Y7MBszxNjCB3_FTo7Tf5biHkJPf55wfgE4rGH2aS2L4)
Here's after the fix:
![image](https://private-user-images.githubusercontent.com/22198661/410162802-90491979-7416-46bb-9295-79a5dcb1f339.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTc5MzUsIm5iZiI6MTczOTU5NzYzNSwicGF0aCI6Ii8yMjE5ODY2MS80MTAxNjI4MDItOTA0OTE5NzktNzQxNi00NmJiLTkyOTUtNzlhNWRjYjFmMzM5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA1MzM1NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM4NGFlMDU2NzA4MWIzY2M0ZGQ0NDFiMmExZWM1MTQ4OWQ3YWFiMTRiM2FhZGI5ZjZmNzhhYjRkOWY0NjRkNmQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.qshyZkGDsgjCJY6fe3Mgr3JUg_n8pIp0fRJkp6wcXN0)
🗒 Checklist 🗒