Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use column-major order when constructing GLSL matrices #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reims
Copy link

@reims reims commented Sep 9, 2018

Some functions in the vari part of rtg-math use row-major order when constructing matrices. These matrices then cannot be used with normal GLSL operations because GLSL uses column-major order.

This pull request changes this for most of the functions that construct matrices.

I did not check all functions for this issue. Missing are (in m3 and in m4)

  • rotation-from-euler
  • adjoint
  • from-direction
  • point-at
  • look-at

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant