Remove bitvector lib #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
commented
Jul 31, 2018
| result = value | ||
| else: | ||
| result = bit_vector.shift_left(shift_length).int_val() | ||
| result = (value * 2**shift_length) & constants.UINT_256_MAX |
There was a problem hiding this comment.
A quick test shows that replacing this with (value << shift_length) & constants.UINT_256_MAX passes all the tests.
There was a problem hiding this comment.
Indeed! I have to read up on that magic!
pipermerriam
commented
Jul 31, 2018
| result = value | ||
| else: | ||
| result = bit_vector.shift_right(shift_length).int_val() | ||
| result = (value // 2**shift_length) |
There was a problem hiding this comment.
This one errored out when I changed it to value >> shift_length with an overflow error saying the integer is too large to convert to the c_type, probably something that could be worked around if we're clever.
There was a problem hiding this comment.
It works with the same trick (value >> shift_length) & constants.UINT_256_MAX
There was a problem hiding this comment.
viola! huzzah for simple solutions
cburgdorf
referenced
this pull request
Jul 31, 2018
cburgdorf
force-pushed
the
christoph/feat/opcodes
branch
2 times, most recently
from
9614afb to
888f496
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Un-necessary new library.
How was it fixed?
Figured out how to do it without the library.
Cute Animal Picture