Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mousetrap.js (fix for keyup with multiple modifiers) #317

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

prominentdetail
Copy link

Changes to ensure that keyup fires when combination consists of multiple modifiers and ends with a modifier key.

Changes to ensure that keyup fires when combination consists of multiple modifiers and ends with a modifier key.
This is the start of namespace feature for keybinding. so for example, ctrl+a.name and ctrl+a.name2 could be triggered with same key combination.
If there was a space+c binding for instance, it would fire when c is pressed and not consider space. Now, any key will check to ensure previous keys are still held before firing. If window loses focus, it will clear the arrays that hold the held and released keys.
@magne4000
Copy link

Will this be merged at some time ?

@EmaSuriano
Copy link

Yeah, I'm having this exact same issue ... @ccampbell can you take a look? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants