Skip to content

Conversation

@anshumanks
Copy link
Contributor

@anshumanks anshumanks commented Feb 5, 2025

Refactor upgrade logic to exclude WORKERS in patch upgrades

Description

This change enables excluding certain program types from pre and post upgrade jobs in case of patch upgrades. Primarily being used for WORKERS (replication pipelines).

Code change

  • Modified upgrade-job.yaml, spec.go, version_update.go

Unit Tests

  • Modified version_update_test.go
  • Modified old tests to incorporate new return value from compareVersions function (-2 for patch upgrade)
  • Added a new test to check for patch upgrade

Tested

In case of patch upgrade, extra argument --exclude-program-type=WORKERS is sent to pre upgrade job to exclude WORKERS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants