feat(stateful-set): allow configuring volumeClaimTemplates

[benkeil]

Fixes cdk8s-team/cdk8s#2183

[iliapolo]

Can we accept a Volume here instead? or a VolumeMount?

[benkeil]

I would let it as it is. You could still use the volume as a variable and use name: volume.name, I would not use it like this.

I could also think about something like:

VolumeClaimTemplatesSomeSuffix.fromVolume(volume, {
  storage: Size.gibibytes(20),
  accessModes: [kplus.PersistentVolumeAccessMode.READ_WRITE_ONCE_POD],
  storageClassName: 'standard',
})

But to be honest my absolute favourite would be something like:

new kplus.StatefulSet(chart, 'StatefulSet', {
  containers: [
    {
      image: 'foobar',
      portNumber: 80,
      volumeMounts: [
        {
          volume: Volume.fromClaimTemplate({
            name: "data",
            storage: Size.gibibytes(20),
            accessModes: [kplus.PersistentVolumeAccessMode.READ_WRITE_ONCE_POD],
            storageClassName: 'standard',
          }),
          path: '/mnt/data',
        },
      ],
    },
  ],
})

[iliapolo]

I like Volume.fromClaimTemplate - probably a bit more involved to implement. Don't want to block on it so i'm approving this one. Feel free to add it in a subsequent PR though as an enhancement.

[iliapolo]

@benkeil looks good, you got some build failures though.

[iliapolo]

@benkeil new failures :)

[benkeil]

wait until it runs in my fork

[benkeil]

ok, build was successful

[cdk8s-automation]

💚 All backports created successfully

Status	Branch	Result
✅	k8s-31/main
✅	k8s-32/main

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

[cdk8s-automation]

💚 All backports created successfully

Status	Branch	Result
✅	k8s-31/main
✅	k8s-32/main

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details