types: Add MarshalBinary and UnmarshalBinary methods to EntityUID #126
+130
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h tests Signed-off-by: Ryan Harris <[email protected]>
TheFellow
force-pushed
the
support-binary-marshaler
branch
from
6b5228b to
6772b71
Compare
Signed-off-by: Ryan Harris <[email protected]>
Signed-off-by: Ryan Harris <[email protected]>
TheFellow
force-pushed
the
support-binary-marshaler
branch
from
1c60eb1 to
4ddef61
Compare
philhassey
reviewed
Jan 6, 2026
Signed-off-by: Ryan Harris <[email protected]>
philhassey
reviewed
Jan 6, 2026
philhassey
reviewed
Jan 6, 2026
Signed-off-by: Ryan Harris <[email protected]>
philhassey
approved these changes
Jan 6, 2026
Collaborator
philhassey
left a comment
philhassey
left a comment
There was a problem hiding this comment.
LGTM @patjakdev can you give it a quick second look?
Signed-off-by: Ryan Harris <[email protected]>
patjakdev
approved these changes
Jan 6, 2026
|
|
||
| // UnmarshalCedar parses a Cedar language representation of an EntityUID. | ||
| func (e *EntityUID) UnmarshalCedar(data []byte) error { | ||
| // NB: In a perfect world we'd use the full parsing from internal/parser, but |
Collaborator
There was a problem hiding this comment.
Thanks for writing this up. It's good to document our warts.
| s := string(data) | ||
| idx := strings.Index(s, "::\"") | ||
| if idx <= 0 { | ||
| // If idx == 0, the entity has no type, which is invalid. |
Collaborator
There was a problem hiding this comment.
tiny nit, == should be <=
Alternatively, just remove the comment :)
Collaborator
Author
There was a problem hiding this comment.
Oh, I actually was only referring to the == 0 case for this comment. If we do find the ::" string but it's the first thing then there is no entity type which is also invalid. (There a test that exercises this scenario)
Signed-off-by: Ryan Harris <[email protected]>
Signed-off-by: Ryan Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #125 & #44
I was attempting to use
cedar.EntityUIDs directly as keys in a bstore (bbolt) K/V store but needed to do some juggling to make it work.This PR implements a straightforward variant of
EntityUID.UnmarshalCedarand uses that to implement theencoding.BinaryMarshalerandencoding.BinaryUnmarshalerinterfaces.