refactoring for parse entity. #326
Open
+351
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rializer,EntityIdentifier,EntityUID,EntityUIDTests, also to include the corresponding tests for the refactored methods as well as missing tests for other methods I believe I missed Signed-off-by: Raheim Swaby <[email protected]>
Signed-off-by: Raheim Swaby <[email protected]>
Signed-off-by: Raheim Swaby <[email protected]>
Signed-off-by: Raheim Swaby <[email protected]>
| public JsonEUID(String type, String id) { | ||
| this.type = type; this.id = id; | ||
| this.type = type; | ||
| this.id = id.replace("\\\"", "\""); |
There was a problem hiding this comment.
What exactly are we fixing with this change and how confident are we that it's correct? Escaping is always subtle and easy to do wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.changes to include: JsonEUID, Valuesrializer,EntityIdentifier,EntityUID,EntityUIDTests, also to include the corresponding tests for the refactored methods as well as missing tests for other methods I believe I missed
refactored parse entity and get entity-uid /repr as well as implementing the hash map return method for both FFI and cedar java side of things. Had to tweak a couple thing so that the escape function would work properly work and cooperate with CedarJava and FFI(vice versa).