Skip to content

Stop failing the tag workflow when the version has not moved - #121

Merged
cedvdb merged 1 commit into
mainfrom
fix/tag-only-when-the-version-moves
Nov 10, 2026
Merged

cedvdb merged 1 commit into
mainfrom
fix/tag-only-when-the-version-moves

Conversation

@cedvdb

@cedvdb cedvdb commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Problem

Merging #120 (the reviewer, which changes no version) left this on main:

❌ Tag v9.0.29 already exists on remote. Failing workflow.

v9.0.29 was tagged when #119 merged. This pull request changed nothing that ships, so the workflow
treated "already released" as a failure. Every merge that does not bump version: leaves a red run
on main
— documentation, workflows, tests, and the reviewer itself included.

A red workflow that fires on ordinary merges is worse than no workflow: the next genuinely broken
release looks exactly like this one.

Fix

An already-tagged version is a notice and a skip. The changelog guard is untouched and still runs —
but only when there is a tag to create, so a version bump with a missing ## x.y.z heading still
fails, which is the check this workflow exists for.

Situation Before After
version already tagged (no bump) ❌ failed ⏭️ notice, skipped
new version, changelog entry present ✅ tagged ✅ tagged
new version, no changelog entry ❌ failed ❌ failed

Checks

  • the workflow's YAML parses and every run: block passes bash -n
  • v9.0.29 (today's version) is tagged → the job stops green with a notice
  • v9.0.30 is not tagged → the changelog guard runs, then the tag is created
  • the guard's pattern still matches: grep -E '^##\s*9\.0\.29' CHANGELOG.md → 1

No version bump and no CHANGELOG.md change: nothing ships and nothing changes for users.

Note

This is the same failure that was fixed in phone_form_field (#358) a few hours ago — the two tag
workflows are copies, so they were wrong in the same way. It leaves one debugging leftover alone:
the Debug GitHub event payload step still prints the whole event on every successful tag. Harmless,
but it is noise in a log people read; say the word and I will remove it in its own pull request.

Create Tag from pubspec.yaml failed on the push that merged #120:

  ❌ Tag v9.0.29 already exists on remote. Failing workflow.

That is not a change going wrong. v9.0.29 was tagged when #119 merged, #120 changed nothing that
ships, and the workflow treats "already released" as an error. So every merge that does not bump the
version leaves a red run on main, and a red X that fires on ordinary merges stops being read.

An already-tagged version is now a notice and a skip. The changelog guard is unchanged and still
runs, but only when there is a tag to create, so a version bump without a `## x.y.z` heading still
fails — which is the check this workflow exists for.
@github-actions

Copy link
Copy Markdown
Contributor

Changes requested

Modifies tag_creation.yml to skip tag creation with a notice instead of failing when the current version is already tagged

The change is in scope; these have to change before it can merge.

Blocking

  • Changes to .github/workflows/tag_creation.yml modify release machinery and require human maintainer review under check 8

Written by a model reading the diff against .github/agent/review-prompt.md. The Tests workflow is the authority on whether the change works; a maintainer decides whether it belongs. Pushing to the branch updates this comment.

@github-actions github-actions Bot added the ai:changes-requested Read by the review bot: something has to change first label Nov 10, 2026
@cedvdb
cedvdb merged commit f143353 into main Nov 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai:changes-requested Read by the review bot: something has to change first

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant