Repository navigation
Stop failing the tag workflow when the version has not moved - #121
Merged
Merged
Conversation
Create Tag from pubspec.yaml failed on the push that merged #120: ❌ Tag v9.0.29 already exists on remote. Failing workflow. That is not a change going wrong. v9.0.29 was tagged when #119 merged, #120 changed nothing that ships, and the workflow treats "already released" as an error. So every merge that does not bump the version leaves a red run on main, and a red X that fires on ordinary merges stops being read. An already-tagged version is now a notice and a skip. The changelog guard is unchanged and still runs, but only when there is a tag to create, so a version bump without a `## x.y.z` heading still fails — which is the check this workflow exists for.
Contributor
Changes requestedModifies tag_creation.yml to skip tag creation with a notice instead of failing when the current version is already tagged The change is in scope; these have to change before it can merge. Blocking
Written by a model reading the diff against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Merging #120 (the reviewer, which changes no version) left this on
main:v9.0.29was tagged when #119 merged. This pull request changed nothing that ships, so the workflowtreated "already released" as a failure. Every merge that does not bump
version:leaves a red runon
main— documentation, workflows, tests, and the reviewer itself included.A red workflow that fires on ordinary merges is worse than no workflow: the next genuinely broken
release looks exactly like this one.
Fix
An already-tagged version is a notice and a skip. The changelog guard is untouched and still runs —
but only when there is a tag to create, so a version bump with a missing
## x.y.zheading stillfails, which is the check this workflow exists for.
Checks
run:block passesbash -nv9.0.29(today's version) is tagged → the job stops green with a noticev9.0.30is not tagged → the changelog guard runs, then the tag is createdgrep -E '^##\s*9\.0\.29' CHANGELOG.md→ 1No version bump and no
CHANGELOG.mdchange: nothing ships and nothing changes for users.Note
This is the same failure that was fixed in
phone_form_field(#358) a few hours ago — the two tagworkflows are copies, so they were wrong in the same way. It leaves one debugging leftover alone:
the
Debug GitHub event payloadstep still prints the whole event on every successful tag. Harmless,but it is noise in a log people read; say the word and I will remove it in its own pull request.