Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Feature: urllib3 instead of curl" #2261

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

auvipy
Copy link
Member

@auvipy auvipy commented Mar 15, 2025

Reverts #2134 to fix the performance regression related to #2258

Copy link

codecov bot commented Mar 15, 2025

Codecov Report

Attention: Patch coverage is 61.16505% with 80 lines in your changes missing coverage. Please review.

Project coverage is 81.09%. Comparing base (571dd4d) to head (4d6f525).

Files with missing lines Patch % Lines
kombu/asynchronous/http/curl.py 60.00% 63 Missing and 15 partials ⚠️
kombu/asynchronous/http/__init__.py 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2261      +/-   ##
==========================================
- Coverage   81.57%   81.09%   -0.48%     
==========================================
  Files          77       77              
  Lines        9537     9623      +86     
  Branches     1161     1178      +17     
==========================================
+ Hits         7780     7804      +24     
- Misses       1564     1615      +51     
- Partials      193      204      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a description and link to the issue that triggered this revert so it will be easier to track in the future. Thank you!

@auvipy auvipy added this to the 5.5.1 milestone Mar 16, 2025
@auvipy
Copy link
Member Author

auvipy commented Mar 16, 2025

updated the related issue

@auvipy
Copy link
Member Author

auvipy commented Mar 17, 2025

i think we should revert this change for now

@Nusnus
Copy link
Member

Nusnus commented Mar 17, 2025

i think we should revert this change for now

This change is done across celery, kombu and pytest-celery.
I want to manage this revert op carefully, as we’re deep into the release cycle.

Just merging this will make main incompatible with celery and pytest-celery main.

@auvipy
Copy link
Member Author

auvipy commented Mar 17, 2025

No problem take your time. Sorry if my comments seems pushy, all the open pr are meant to be a supporting hand only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants