Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodebuilder/p2p): fix autonat == nil panic in test #4170

Merged
merged 3 commits into from
Mar 17, 2025

Conversation

renaynay
Copy link
Member

Verified

This commit was signed with the committer’s verified signature.
renaynay rene
@renaynay renaynay added the kind:misc Attached to miscellaneous PRs label Mar 13, 2025
@renaynay renaynay self-assigned this Mar 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 44.86%. Comparing base (2469e7a) to head (dffd671).
Report is 462 commits behind head on main.

Files with missing lines Patch % Lines
nodebuilder/p2p/reachability.go 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4170      +/-   ##
==========================================
+ Coverage   44.83%   44.86%   +0.02%     
==========================================
  Files         265      310      +45     
  Lines       14620    22732    +8112     
==========================================
+ Hits         6555    10198    +3643     
- Misses       7313    11448    +4135     
- Partials      752     1086     +334     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Wondertan
Copy link
Member

Ahh, I guess I didn't look at integration tests...
We need to fix them otheriwise I'll keep ignoring them 😂

Verified

This commit was signed with the committer’s verified signature.
renaynay rene
@renaynay renaynay requested a review from cristaloleg March 14, 2025 13:06

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@cristaloleg cristaloleg enabled auto-merge (squash) March 17, 2025 14:54
@cristaloleg cristaloleg merged commit b153088 into celestiaorg:main Mar 17, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:misc Attached to miscellaneous PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants