core: return explicit error on AddPartWithoutProof ok=false in partsToBlock #4644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes incorrect error handling in partsToBlock where a false ok result from PartSet.AddPartWithoutProof led to returning nil, err with err being nil, effectively masking failures such as duplicate or otherwise non-added parts. By returning a concrete error with context (part index) when ok is false, we ensure block reconstruction errors are surfaced to callers, aligning with CometBFT semantics that reserve non-nil err for validation failures and use ok=false for non-added cases (commonly duplicates). This prevents silent success, improves diagnosability, and maintains correct behavior in higher-level consumers like receiveBlockByHeight/receiveBlockByHash, Listener, and Exchange.