fix: xtoken discrepancies #4676
Open
+231
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gupadhyaya
requested review from
Wondertan,
renaynay,
vgonkivs and
walldiss
as code owners
renaynay
reviewed
Oct 31, 2025
nodebuilder/core/constructors.go
Outdated
| "github.com/celestiaorg/celestia-node/libs/utils" | ||
| ) | ||
|
|
||
| var log = logging.Logger("core") |
There was a problem hiding this comment.
Suggested change
| var log = logging.Logger("core") | |
| var log = logging.Logger("nodebuilder/core") |
| defaultGRPCMessageSize = 64 * 1024 * 1024 // 64Mb | ||
|
|
||
| xtokenFileName = "xtoken.json" | ||
| xtokenFileName = "xtoken.json" |
There was a problem hiding this comment.
why? there are only two file names: xtoken.json or x-token.json
| // Support "x-token" (preferred), "xtoken", and "token" JSON keys for maximum compatibility | ||
| auth := struct { | ||
| Token string `json:"x-token"` | ||
| XToken string `json:"x-token"` |
There was a problem hiding this comment.
this can be simplified
Just construct the auth token when you successfully read from one of the expected file names.
There was a problem hiding this comment.
wdym? i am reading from the expected file names, but the token name can be either of these three (x-token | xtoken | token) hence the struct and unmarshal. can u clarify?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4676