[wip]: perf(types): compute commitment roots without retaining NMT leaves - #982
Draft
citizen-stig wants to merge 1 commit into
Draft
[wip]: perf(types): compute commitment roots without retaining NMT leaves#982citizen-stig wants to merge 1 commit into
citizen-stig wants to merge 1 commit into
Conversation
(cherry picked from commit 5ac130a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 5ac130a)
Overview
Commitment::from_sharesbuilt a full Nmt per subtree, andnmt-rscopies every 512-byte leaf into the tree (15,229 leaves for 7 MiB) plus grows a leaf vector.Replaced with an incremental merkle fold (
nmt_subtree_root) that computes each subtree root directly with SHA-256, keeping only O(log n) intermediate hashes.Correctness is pinned by a new test comparing against the previous nmt-rs implementation across share versions, namespaces, and 40+ sizes.
Impact: one commitment pass −22.9 MB cumulative, −61,882 allocations; full construct+submit −45.8 MB, −123,767 allocations (commitment is computed twice: Blob::new and Blob::validate). Largest single win in the stack.
Related to #862