Skip to content

Conversation

oltolm
Copy link
Contributor

@oltolm oltolm commented Jul 23, 2025

I wanted to get rid of the non-standard wxCheckTree in the "Graphic packs" window. I replaced it with a wxTreeListViewCtrl. I think that it looks better because you now have three states checkboxes and you can see where there are active options. The only thing that was lost are colors.

graphic packs

@Crementif
Copy link
Member

Crementif commented Jul 23, 2025

I like the idea to remove some of the antiquated custom controls with new features that are provided by wxWidgets, but I think not having the colors is a pretty big downgrade in terms of usability and clarity. I don't think the middle state checkboxes really add anything, and I don't really think we should have users be able to mass-enable ALL graphic packs for a game without knowing what they're enabling. Unless it's possible to have the colors too, I don't think it's worth replacing our custom solution. But up to Exzap whether he agrees with me.

@oltolm
Copy link
Contributor Author

oltolm commented Jul 23, 2025

You can not mass-enable options. All inner nodes are read-only. You can only change leafs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants