set pg_num when autoscale_mode=warn #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asm0deuz
requested changes
Oct 2, 2025
Collaborator
|
@stryan Please sign-off your commit and the explanation in the PR message in the commit message. Thx |
Author
|
@asm0deuz Updated and put PR message and sign-off in commit. Do you want me to squash the two commits into one? I wasn't sure if the sign-off needs to be on all commits in the PR or not. |
Collaborator
|
Please squash both commits into one and rebase before pushing, it will update the github actions. |
ceph_pool will only set the pg_num and pgp_num options when the auto_scaler is set to off. While it makes sense not to set them when the auto_scaler is on, the auto_scaler can also be set to "warn" mode where it will not adjust the PG count either. It seems counterintuitive to not allow configuring pg count in that case. Signed-off-by: stryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds "warn" mode as a valid state setting the
pg_num/etc on pool creation.ceph_poolwill only set thepg_numandpgp_numoptions when the auto_scaler is set to off. While it makes sense not to set them when the auto_scaler is on, the auto_scaler can also be set to "warn" mode where it will not adjust the PG count either. It seems counterintuitive to not allow configuring pg count in that case.