Add frozen_string_literal magic comment #1408
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopting the almost ubiquitous
frozen_string_literal
magic comment to ensure efficient string storage. I observed that we don't mutate any of the string literals after we have declared them which implies that, in essence, they're already treated as frozen values. Invoking the magic comment is only a clue to the Ruby VM to optimize the strings.Closes #1407.
All Submissions:
Test Plan:
All existing tests pass.
Reviewer Checklist: