Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restricting default railties version to be < 7 #1416

Closed
wants to merge 1 commit into from

Conversation

Kallin
Copy link

@Kallin Kallin commented Oct 17, 2023

Resolves #1415

All Submissions:

  • [X ] I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • [ X] I've submitted a ticket for my issue if one did not already exist.
  • [ X] My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • [ X] I've used Github auto-closing keywords in the commit message or the description.
  • [X ] I've added/updated tests for this change.

Bug fixes and Changes to Core Features:

  • [X ] I've included an explanation of what the changes do and why I'd like you to include them.
  • [ X] I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@@ -23,7 +23,7 @@ when 'master'
gem 'railties', { git: 'https://github.com/rails/rails.git' }
gem 'arel', { git: 'https://github.com/rails/arel.git' }
when 'default'
gem 'railties', '>= 6.0'
gem 'railties', '>= 6.0', '< 7'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the Gemfile this would be a development level concern. what you're intention which stopping development testing against Rails 7 but not stopping releases from using it?

Also, since you're targeting master/main, which release are you on?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now master doesn't seem compatible w/ Rails 7; as I noted in the issue, when you check out the repository but don't specify rails version, it will pick up latest (7.x at present), and tests will fail. I opened this as it threw me for a loop when trying to get started on development w/ this project.

Copy link
Collaborator

@bf4 bf4 Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now master doesn't seem compatible w/ Rails 7;

why are you targeting master, though? If you're interesting in beginning with development, you should start with branch v0-11-dev (which is known to be failing on Rails 7.1 right now)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I first came to this project I had no way of knowing that active development wasn't off of master, I simply followed the 'contributing' directions in the README.

Copy link
Collaborator

@bf4 bf4 Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem. Usually that's true. Just not at this precise moment. Thanks for getting involved!

@bf4
Copy link
Collaborator

bf4 commented Oct 27, 2023

Closing as OP intent is app development, which is happening on v0-11-dev and there's no intention to restrict development to Rails 6.

@bf4 bf4 closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to build w/o specifying rails version in ENV
2 participants