Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine relationship method creation and implicit relationships #1445

Closed
wants to merge 2 commits into from

Conversation

lgebhardt
Copy link
Member

Allows the implicit relationships to be tracked separately from the primary relationships, and recreate them through the normal process on derived classes.

Also recreates the relationship methods on the derived class as a separate step after the resource classes are all defined.
TODO: Test that this is working

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

Moves the bulk of the active_record file before the app initialization,
but leaves the database after.
…methods

until the app is initialized

This will prevent derived classes from inheriting the relationship methods from the base class
@lgebhardt lgebhardt closed this Jan 27, 2024
@lgebhardt lgebhardt deleted the v0-11-dev-refine-implicit-relationships branch January 27, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant