This repository has been archived by the owner on May 24, 2024. It is now read-only.
Update index js #334
Merged
Update index js #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroshk
approved these changes
Apr 2, 2024
sdadn
commented
Apr 2, 2024
Comment on lines
+3
to
+4
| // TODO: update to pull scss from the src/lib folder instead of dist | ||
| import '../dist/css/carbon-graphs.css'; |
There was a problem hiding this comment.
Note: This is a temporary fix to automatically import all necessary files. This will be replaces with scss files in the future.
artpark
approved these changes
Apr 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR continues the work in #332 by updating index.js to also import the css. Now, css no longer has to be explicitly imported when consuming graphs.
Before:
After
Testing
This change was tested using:
This was tested by ensuring there are no css changes in screenshots. Removing the css import causes the css to break, which confirms that this change works.
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
Thank you for contributing to Terra.
@cerner/terra