Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance clarification for region name/area types #290

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Conformance clarification for region name/area types #290

merged 1 commit into from
Apr 30, 2021

Conversation

RosalynHatcher
Copy link
Contributor

@RosalynHatcher RosalynHatcher commented Jul 24, 2020

Clarification to conformance document for region names/area_types to allow use of flag_values and flag_meanings as per discussion in #198. This was a PR that got missed before the conformance document was moved into the cf-conventions repository.

See issue #198 for discussion of these changes.

Release checklist

  • Authors updated in cf-conventions.adoc?
  • Next version in cf-conventions.adoc up to date? Versioning inspired by SemVer.
  • history.adoc up to date?
  • Conformance document up-to-date?

For maintainers

After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then master always is a draft for the next version.

…es/area_types to allow use of flag_values and flag_meanings as per discussion in #198
@davidhassell
Copy link
Contributor

Hi @RosalynHatcher Thanks for this. As this original discussion was concluded and agreed, I don't think we need to wait the usual three weeks before merging this - it's essentially a housekeeping task, now.

Could you make a note of a link to the unmerged PR in the old conformance repo, for the record?

@RosalynHatcher
Copy link
Contributor Author

Original PR in the conformance repos is cf-convention/Conformance#10

@davidhassell davidhassell added this to the 1.9 milestone Apr 30, 2021
@davidhassell davidhassell merged commit a4aea91 into cf-convention:master Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants