Cleanup for apps-install script #3834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anselmbradford
force-pushed
the
script_cleanup
branch
from
18f737c to
980384f
Compare
sebworks
approved these changes
Feb 28, 2018
anselmbradford
force-pushed
the
script_cleanup
branch
from
980384f to
23bb897
Compare
sebworks
reviewed
Mar 1, 2018
scripts/npm/apps-install/index.js
Outdated
| /* Check if node_modules directory exists in a particular app's folder. | ||
| If it doesn't log the command to add it and don't process the scripts. */ | ||
| /* Check if package.json exists in a particular app's folder. | ||
| If it does, run npm install on that directory. */ | ||
| const appsPath = `${ paths.unprocessed }/apps/${ app }`; | ||
| // eslint-disable-next-line no-sync | ||
| if ( fs.existsSync( `${ appsPath }/package.json` ) ) { | ||
| exec( `npm --prefix ${ appsPath } install ${ appsPath }`, |
There was a problem hiding this comment.
Swap this out for execSync.. You want this to be blocking, you will need to modify the code to use try / catch. See https://github.com/cfpb/cfgov-refresh/pull/3840/files#diff-269192501d1bd2ea09c118162a0ab16aR29
sebworks
reviewed
Mar 1, 2018
scripts/npm/apps-install/index.js
Outdated
| // eslint-disable-next-line no-console | ||
| console.log( `npm errors/warnings from ${ appsPath }: ${stderr}` ); | ||
| } | ||
|
|
||
| if ( error !== null ) { |
There was a problem hiding this comment.
You want to kill the process on error, especially since frontend.sh will complete and you won't be able to run the script again ( the checksum value gets added ).
anselmbradford
force-pushed
the
script_cleanup
branch
from
ff74c9d to
82cab4e
Compare
|
@sebworks please re-pull and check pls! |
|
💯, I'm not sure on the linting error. |
sebworks
approved these changes
Mar 1, 2018
|
I removed the final if statement, because if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address @Scotchester comments in #3831
Removals
package-lock.json.Changes
Testing