Implemented Github Actions for Mac and Added Mac Compatibility #6
Conversation
steel-bucket
commented
Apr 1, 2025
steel-bucket
commented
- Added Mac compatibility
- Added Actions which builds and tests the code for Mac.
- For Mac it was simple, as it's unix based, I just had to make the test_continuous_output_does_not_timeout time to 5 seconds instead of 3.
steel-bucket
changed the title
src/lib.rs
Outdated
| result.duration < Duration::from_secs(3), | ||
| "Duration should be < 3s" | ||
| result.duration < Duration::from_secs(5), | ||
| "Duration should be < 5s" |
There was a problem hiding this comment.
Somehow not running without it
There was a problem hiding this comment.
Should I do some research?
There was a problem hiding this comment.
Should I do some research?
Yes, we can't merge something without understanding what's going on :-)
There was a problem hiding this comment.
@cfsmp3 Okay, so I did some research. First I thought that the problem was that "sleep" was taking slightly more time in macos. So I tried with bash and zsh, but they didn't work. Then I tried to perform the timing before the draining, that didn't work. Then I started looking for the functions that may be different for Linux and Mac in the code and not just in the tests. I thought the libc::setpgid would be the difference so I tried replacing it with nix::unistd::setpgid, but that didn't work either, and debugging showed that the duration is unchanged after setpgid.
So now, the thing that I'm almost sure of is that the slight time change originates from the killpg function, so I guess Mac takes slightly more time killing the application.
I've modified the tests for asserting different duration for Linux and Mac. Please suggest any changes.
Thank you.
steel-bucket
force-pushed
the
github-actions-mac
branch
from
7ec33b1 to
c3e48e5
Compare
steel-bucket
force-pushed
the
github-actions-mac
branch
from
a211626 to
2f32614
Compare
2 participants
