🔥 Removes last traces of legacy dart:html library in dio packages - #2609
Open
mkustermann wants to merge 1 commit into
Open
mkustermann wants to merge 1 commit into
mkustermann wants to merge 1 commit into
Conversation
This removes any traces of the legacy `dart:html` library, including conditional import conditions using `if (dart.library.html)`. This raises the SDK to 3.3.0 where `dart:js_interop` was introduced (i.e. min SDK is from Feb 2024). Raising the min SDK also leads to a number of other cleanups in the code base: * removing unnecessary breaks in switch statements * simplifying `kIsWeb` conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes last traces of the legacy
dart:htmllibrary in the code. Especiallyconditional imports using
if (dart.library.html).This raises the SDK to 3.3.0 where
dart:js_interopwas introduced (i.e. min SDK is from Feb 2024).Raising the min SDK also leads to a number of other cleanups in the code base.
This also aligns the version with what's written already in the support matrix
in plugins/web_adapter/README.md (namely Dart 3.3.0 and Flutter 3.19.0)
(The
dart:js_interoplibrary was deprecated long ago and originally announcedto be deleted end of 2025, but that was postponed. We're coming closer to removing
it and would like all stable dart packages on pub.dev to be free of legacy web
library uses.)