Skip to content

Conversation

jflan-dd
Copy link
Contributor

@jflan-dd jflan-dd commented Aug 27, 2025

Ignore errors from swift package commands caused by executable products depending on binary targets

Work around #1781 (comment)

@cgrindel
Copy link
Owner

@Mergifyio queue

Copy link
Contributor

mergify bot commented Aug 30, 2025

queue

🟠 Waiting for conditions to match

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-success = all_ci_tests
        • check-neutral = all_ci_tests
        • check-skipped = all_ci_tests
      • any of: [🛡 GitHub branch protection]
        • check-success = conventional_commit_check
        • check-neutral = conventional_commit_check
        • check-skipped = conventional_commit_check
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

Copy link
Owner

@cgrindel cgrindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like tidy is failing. I saw at least one issue with the doc string for the new function. Once things are green, we should be good to go.

@jflan-dd
Copy link
Contributor Author

jflan-dd commented Sep 2, 2025

@cgrindel I updated the doc comment. bazel run //:tidy didn't catch it and I didn't realize that bazel test //... would test only the internal rule tests rather than also running the various example tests. I'll add that to my workflow when contributing here.

@brentleyjones brentleyjones dismissed cgrindel’s stale review September 2, 2025 15:09

Addressed feedback.

@brentleyjones
Copy link
Collaborator

@Mergifyio queue

Copy link
Contributor

mergify bot commented Sep 2, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at f834803

@cgrindel
Copy link
Owner

cgrindel commented Sep 2, 2025

@cgrindel I updated the doc comment. bazel run //:tidy didn't catch it and I didn't realize that bazel test //... would test only the internal rule tests rather than also running the various example tests. I'll add that to my workflow when contributing here.

If you want to run the examples locally, there are //:smoke_integration_tests and //:all_integration_tests. However, I tend to create a draft PR and let GitHub run them in parallel.

@mergify mergify bot merged commit f834803 into cgrindel:main Sep 2, 2025
36 checks passed
@jflan-dd jflan-dd deleted the jflan/spm-binary-executable-workaround branch September 2, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants