feat: add eventEmitter#1693
Conversation
|
Both Node and the browser has |
|
that's a good suggestion, went ahead and tried replacing the underlying event emitter with the EventTarget. There's some book keeping necessary in this case, but nothing too bad. What do you think? |
48439c1 to
250dd48
Compare
|
@43081j for a second review. |
keithamus
left a comment
There was a problem hiding this comment.
LGTM modulo fixing the lint issues.
|
oh I missed those! added the |
|
just for some context, can you give me an example of the usage of this? the change makes sense but i'd like to see how it'll be used |
|
@43081j prodatakey/dirty-chai#54 - |
|
I understand now 👍 I missed that they're not overriding members but are just adding extra ones Makes sense |
|
could this be published? I would like to go on with a PR to use this feature in |
This is motivated by a discussion we had in the
dirty-chairepo here.I used the
eventemitter3module in order to have the same behavior in the browser as in nodejs, but it might not be the optimal choice.my hope is that this facilitates the upgrade of
dirty-chaito support chai 5