Oko-395 #121

Ryz0nd · 2025-12-15T08:51:10Z

Pull Request

Thank you for raising a Pull Request. Please follow the instruction.

I’ve read CONTRIBUTING.md and followed the guidelines.

Summary

oko_sdk_sol

Links (Issue References, etc, if there's any)

eldenpark · 2025-12-18T11:18:59Z

This needs to be merged w/ #131 somehow @Ryz0nd

eldenpark · 2025-12-19T06:51:21Z

@Ryz0nd Dan, could you resolve conflicts? Also, you don't have to define the API handlers for now

Ryz0nd · 2025-12-19T07:01:08Z

Got it, fixing now.

backend/tss_api/src/routes/keygen_ed25519.ts

backend/tss_api/src/routes/sign_ed25519.ts

backend/tss_api/src/routes/user.ts

Ryz0nd · 2025-12-19T08:00:16Z

@eldenpark I removed the code changes in tss-api, oko-attached, and oko-sdk-core, excluding the teddsa code.
The teddsa code was intentionally kept and renamed with a _mock suffix so that @lidarbtc can refer to it later.

Ryz0nd · 2025-12-19T08:02:08Z

oko-sdk-sol is private now, so it won’t be published to npm.

eldenpark · 2025-12-22T08:46:34Z

Is this ready to review? @Ryz0nd

Ryz0nd · 2025-12-22T08:54:54Z

@eldenpark I’m still working on this branch. I’ll continue on the next branch and clean up the code, then ping you again.

Ryz0nd · 2025-12-22T09:09:02Z

It's ready for review. @eldenpark

The newly added TEDDSA-related code is for reference only. Since the changes to TSS and oko-sdk-core were reverted, oko-sdk-sol and sandbox-sol are not functioning properly at the moment.

This reverts commit 71100d4.

This reverts commit c33f333.

This reverts commit 6be157c.

This reverts commit 71100d4.

This reverts commit c33f333.

This reverts commit 6be157c.

eldenpark · 2025-12-22T15:26:11Z

sandbox/sandbox_sol/src/components/sign_transaction_widget.tsx

+  }, [fetchBalance]);
+
+  const handleSignTransaction = async () => {
+    if (!okoSolWallet || !publicKey) return;


Please don't omit curly brackets when definining if conditional

eldenpark · 2025-12-22T15:26:21Z

sandbox/sandbox_sol/src/components/sign_transaction_widget.tsx

+  };
+
+  const handleSendTransaction = async () => {
+    if (!okoSolWallet || !publicKey) return;


eldenpark · 2025-12-22T15:26:59Z

sandbox/sandbox_sol/src/components/sign_transaction_widget.tsx

+        <div className={styles.balanceRow}>
+          <span className={styles.balanceLabel}>Balance:</span>
+          <span className={styles.balanceValue}>
+            {isLoadingBalance


Can we calculate this value before returning?

eldenpark · 2025-12-22T15:27:26Z

sandbox/sandbox_sol/src/components/sign_transaction_widget.tsx

+  LAMPORTS_PER_SOL,
+} from "@solana/web3.js";
+import { useSdkStore } from "@/store/sdk";
+import bs58 from "bs58";


external dep

eldenpark · 2025-12-22T15:27:33Z

sandbox/sandbox_sol/src/components/sign_message_widget.tsx

+  const [error, setError] = useState<string | null>(null);
+
+  const handleSignMessage = async () => {
+    if (!okoSolWallet) return;


eldenpark · 2025-12-22T15:27:51Z

crypto/teddsa/teddsa_wasm_mock/wasm/Cargo.toml

+
+[dependencies]
+teddsa_keplr_mock = { path = "../../teddsa_keplr_mock" }
+wasm-bindgen = "0.2.100"


empty line will help here

nope, I'm taking it back

eldenpark · 2025-12-22T15:29:09Z

crypto/teddsa/teddsa_hooks_mock/src/types.ts

+/**
+ * TEdDSA keygen output for a single participant
+ */
+export interface TeddsaKeygenOutputBytes {


Types defined in this file may later be moved to some common location (no action required as of now)

Ryz0nd changed the title ~~oko-sdk-sol~~ Oko-395 Dec 15, 2025

Ryz0nd force-pushed the dan/oko-sdk-svm branch from ada63ad to 18c709e Compare December 19, 2025 07:09

github-advanced-security bot found potential problems Dec 19, 2025

View reviewed changes

backend/tss_api/src/routes/keygen_ed25519.ts Fixed Show fixed Hide fixed

backend/tss_api/src/routes/sign_ed25519.ts Fixed Show fixed Hide fixed

backend/tss_api/src/routes/sign_ed25519.ts Fixed Show fixed Hide fixed

backend/tss_api/src/routes/user.ts Fixed Show fixed Hide fixed

Ryz0nd marked this pull request as ready for review December 19, 2025 08:00

Ryz0nd added 18 commits December 22, 2025 18:56

oko_sdk_sol: add oko_sdk_sol interface skeleton

8aa6498

crypto: add teddsa rust implementation (FROST Ed25519)

196256e

crypto: add teddsa typescript packages

2e2426c

backend/tss_api: add ed25519 keygen and sign endpoints

90a033e

sdk/oko_sdk_core: add solana types and update oauth

cc33178

sdk/oko_sdk_sol: implement wallet signing methods

99fcaea

embed/oko_attached: integrate solana signing with teddsa

8bded4c

sandbox: add sandbox_sol for solana testing

666184b

chore: update dependencies

fe54cf1

teddsa: rename packages with _mock suffix

ad535f7

o

866bb2a

crypto: use local frost_ed25519 implementation in teddsa_keplr_mock

abbcddd

o

9b57710

Revert "embed/oko_attached: integrate solana signing with teddsa"

b8ddf52

This reverts commit 71100d4.

Revert "sdk/oko_sdk_core: add solana types and update oauth"

e2fc9ec

This reverts commit c33f333.

Revert "backend/tss_api: add ed25519 keygen and sign endpoints"

6ff7e1f

This reverts commit 6be157c.

o

8001eb5

o

fec8fd9

Ryz0nd added 15 commits December 22, 2025 19:10

oko_sdk_sol: add oko_sdk_sol interface skeleton

633ad8a

crypto: add teddsa rust implementation (FROST Ed25519)

db5cd4c

crypto: add teddsa typescript packages

8756cb0

backend/tss_api: add ed25519 keygen and sign endpoints

1531330

sdk/oko_sdk_core: add solana types and update oauth

efd16dd

embed/oko_attached: integrate solana signing with teddsa

b2d9ef3

chore: update dependencies

d8d4d22

teddsa: rename packages with _mock suffix

fa18a6b

o

e7811f2

crypto: use local frost_ed25519 implementation in teddsa_keplr_mock

8a8fa76

Revert "embed/oko_attached: integrate solana signing with teddsa"

a15fbfe

This reverts commit 71100d4.

Revert "sdk/oko_sdk_core: add solana types and update oauth"

feedee0

This reverts commit c33f333.

Revert "backend/tss_api: add ed25519 keygen and sign endpoints"

ebfdbea

This reverts commit 6be157c.

o

4a5958e

o

528a197

Ryz0nd force-pushed the dan/oko-sdk-svm branch from 49d472b to 528a197 Compare December 22, 2025 10:14

eldenpark requested changes Dec 22, 2025

View reviewed changes

eldenpark added 3 commits December 22, 2025 07:42

Merge branch 'main' into dan/oko-sdk-svm

ca47352

o

ec0c823

o

8899b2d

eldenpark merged commit b113193 into main Dec 22, 2025
3 checks passed

Oko-395 #121

Oko-395 #121

Uh oh!

Conversation

Ryz0nd commented Dec 15, 2025

Pull Request

Summary

Links (Issue References, etc, if there's any)

Uh oh!

eldenpark commented Dec 18, 2025

Uh oh!

eldenpark commented Dec 19, 2025

Uh oh!

Ryz0nd commented Dec 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ryz0nd commented Dec 19, 2025

Uh oh!

Ryz0nd commented Dec 19, 2025

Uh oh!

eldenpark commented Dec 22, 2025

Uh oh!

Ryz0nd commented Dec 22, 2025

Uh oh!

Ryz0nd commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Ryz0nd commented Dec 22, 2025 •

edited

Loading