oko 372 #143
oko 372 #143
Conversation
- and add SignerAddressOrEmailForSiwe to be applied other style
- oko 504
- oko-503
| "oko-sandbox-evm": { | ||
| path: path.join(paths.root, "sandbox/sandbox_evm"), | ||
| }, |
There was a problem hiding this comment.
I’m not sure we need to deploy sandbox_evm to Vercel. What are your thoughts?
There was a problem hiding this comment.
First, the reason this was added to the current code was that I needed to deploy sandbox_evm for QA purposes.
For EVM features like EIP-712 and SIWE signature UI, using sandbox_evm is definitely more convenient, so I think it could be useful in the future as well.
| @@ -0,0 +1,35 @@ | |||
| import type { Theme } from "@oko-wallet/oko-common-ui/theme"; | |||
|
|
|||
| import { OKO_PUBLIC_S3_BUCKET_URL } from "@oko-wallet-attached/requests/endpoints"; | |||
There was a problem hiding this comment.
How about using static assets instead of fetching from S3?
There was a problem hiding this comment.
For some reasons (actually I don't remember detailed) we store image in S3.
so @eldenpark How about putting it in the codebase instead of S3?
| <picture> | ||
| <source srcSet={imageUrl.webp} type="image/webp" /> | ||
| <img | ||
| className={styles.image} | ||
| src={imageUrl.png} | ||
| alt="sign siwe title image" | ||
| /> | ||
| </picture> |
There was a problem hiding this comment.
It would also be good to use the newly updated ImageWithAlt component.
Pull Request
CONTRIBUTING.mdand followed the guidelines.Summary
Links (Issue References, etc, if there's any)