[demo_web] add isSignedInRef to track recent state in getKey callback #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldenpark
reviewed
Nov 12, 2025
apps/demo_web/src/hooks/wallet.ts
Outdated
| okoCosmos | ||
| .getKey("cosmoshub-4") | ||
| .then((key) => setCosmosAddress(key.bech32Address)), | ||
| okoCosmos.getKey("cosmoshub-4").then((key) => { |
Contributor
Author
There was a problem hiding this comment.
Do you think make it constant vars?
I just thought it is used just one time and in local
Collaborator
There was a problem hiding this comment.
Yes, it'd be better if we have const COSMOSHUB_4
eldenpark
reviewed
Nov 14, 2025
| const okoEth = useSDKState((state) => state.oko_eth); | ||
| const isSignedIn = useUserInfoState((state) => state.isSignedIn); | ||
| const isSignedRef = useRef(isSignedIn); | ||
| isSignedRef.current = isSignedIn; |
Contributor
Author
There was a problem hiding this comment.
To reference the latest state of isSignedIn in the callback, add a ref variable.
^ as I mentioned PR, Within the callback function, it is necessary to retrieve the most recent isSignedIn state.
Collaborator
There was a problem hiding this comment.
@blacktoast I still don't see why this ref is necessary. Could we hop on a short call when you are available?
Collaborator
|
btw, this has some conflicts. Could you take a look into it? @blacktoast |
eldenpark
reviewed
Nov 17, 2025
| @@ -0,0 +1 @@ | |||
| export const COSMOS_CHAIN_ID = "cosmoshub-4"; | |||
Collaborator
There was a problem hiding this comment.
constants can be anything. Too general this file is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
CONTRIBUTING.mdand followed the guidelines.Summary
구현 사항
isSignedInin the callback, add a ref variable.yarn checkto formatLinks (Issue References, etc, if there's any)